BAEL-1388 Introduction to Java MSF4J Microservices#4192
Conversation
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
The code looks good, let's just simplify the build configuration if we can.
| <version>1.0.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Looks like you might have accidentally committed a conflict
| <module>metrics</module> | ||
| <module>maven</module> | ||
| <module>mesos-marathon</module> | ||
| <module>msf4j</module> |
| <groupId>com.baeldung</groupId> | ||
| <version>1.0.0-SNAPSHOT</version> | ||
| </parent> | ||
| <modules> |
There was a problem hiding this comment.
Typically, it's preferred to differentiate examples by package instead of by maven module. Would you be able to condense this to one project, msf4j, and then separate the examples by package?
| @@ -0,0 +1,143 @@ | |||
| @REM ---------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
We don't need the maven wrappers at this level. What we have at the parent level is fine, so let's remove these.
| @@ -0,0 +1,25 @@ | |||
| /target/ | |||
There was a problem hiding this comment.
I'm guessing these might have been added by start.spring.io? You should be able to remove them all, relying on the .gitignore in the parent.
|
Hi there, I've put together the three projects in a single one, using different package names. Maven wrappers and other files are gone now. |
3 participants
PR for the BAEL-1388 Introduction to Java MSF4J Microservices article