Adding source code for article tracked under BAEL-3172.#7540
Merged
Conversation
|
|
||
| <parent> | ||
| <artifactId>parent-boot-2</artifactId> | ||
| <groupId>com.baeldung</groupId> |
Contributor
There was a problem hiding this comment.
Let's reindent with spaces instead of tabs.
|
|
||
| ScriptEngine nashorn = new ScriptEngineManager().getEngineByName("nashorn"); | ||
|
|
||
| nashorn.eval(new FileReader("./src/main/webapp/js/react.js")); |
Contributor
There was a problem hiding this comment.
I don't think these src/main paths will work once the app is packaged and deployed
| var last = this.state.data[this.state.data.length-1]; | ||
| var secondLast = this.state.data[this.state.data.length-2]; | ||
| $.ajax({ | ||
| url: 'http://localhost:8080/next/'+last+'/'+secondLast, |
Contributor
There was a problem hiding this comment.
switch the URLs in this file to relative URLs
pivovarit
approved these changes
Aug 21, 2019
| var last = this.state.data[this.state.data.length-1]; | ||
| var secondLast = this.state.data[this.state.data.length-2]; | ||
| $.ajax({ | ||
| url: 'http://localhost:8080/next/'+last+'/'+secondLast, |
Contributor
There was a problem hiding this comment.
Should this be a relative URL rather than absolute hardcoded to localhost:8080?
Contributor
Author
|
@pivovarit , This CI build seems to have been aborted, anyway, this can be retriggered? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.