minor text fixes#286
Merged
Merged
Conversation
Collaborator
Author
|
fwiw, Psi4 has been using set_sho after initialize for months https://github.com/psi4/psi4/blob/master/psi4/src/core.cc#L1060-L1068 without problems. gtk that's not advised; I'll switch it around. |
Owner
as long as it's immediately after it's fine ... but it's easier in the dox to say before ... passing as an arg to initialize would be best, of course, but I understand the python issues (would giving |
evaleev
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a couple typos and correct
set_solid_harmonics_orderingadvice after new comment in #285initialize.h