Skip to content

minor text fixes#286

Merged
evaleev merged 2 commits into
evaleev:masterfrom
loriab:loriab-patch-1
Nov 27, 2023
Merged

minor text fixes#286
evaleev merged 2 commits into
evaleev:masterfrom
loriab:loriab-patch-1

Conversation

@loriab
Copy link
Copy Markdown
Collaborator

@loriab loriab commented Nov 27, 2023

Fix a couple typos and correct set_solid_harmonics_ordering advice after new comment in #285 initialize.h

@loriab
Copy link
Copy Markdown
Collaborator Author

loriab commented Nov 27, 2023

fwiw, Psi4 has been using set_sho after initialize for months https://github.com/psi4/psi4/blob/master/psi4/src/core.cc#L1060-L1068 without problems. gtk that's not advised; I'll switch it around.

@evaleev
Copy link
Copy Markdown
Owner

evaleev commented Nov 27, 2023

fwiw, Psi4 has been using set_sho after initialize for months https://github.com/psi4/psi4/blob/master/psi4/src/core.cc#L1060-L1068 without problems. gtk that's not advised; I'll switch it around.

as long as it's immediately after it's fine ... but it's easier in the dox to say before ... passing as an arg to initialize would be best, of course, but I understand the python issues (would giving verbose argument a stronger type solve that issue?)

@evaleev evaleev merged commit 01e72e7 into evaleev:master Nov 27, 2023
@loriab loriab deleted the loriab-patch-1 branch November 27, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants