Skip to content

full cmake 6/N: generator#315

Merged
evaleev merged 20 commits into
evaleev:masterfrom
loriab:generator
Oct 13, 2025
Merged

full cmake 6/N: generator#315
evaleev merged 20 commits into
evaleev:masterfrom
loriab:generator

Conversation

@loriab
Copy link
Copy Markdown
Collaborator

@loriab loriab commented Dec 28, 2023

Currently atop #314 but has also been rebased to master so atop 2.8.1 . New stuff in 85e20ce .

  • builds and runs the generator/compiler. A counterpart GHA has been added to test these stages for Mac & Linux.
  • added a cmake file to prevent in-source builds. Requires setting CMAKE_BUILD_TYPE explicitly (or I can put in a default). Multiconfig generators seem unlikely with L2.
  • testing enabled by usual cmake var BUILD_TESTING. Between master and the 2022/2023 CMake PRs, compiler tests and library tests changed places as being in top-level tests/ (see chart below). I was going to keep all the files in-place for now so that libtool and cmake can share. The main test.cc is in place and running through check-libint2compiler target.
  • the main libtool generator test seems to be the test_eri/ that generates a dozen or so mini libraries and runs them through a tester. you didn't migrate this along with the other tests in ~2022, but it probably should be?
  • windows. I carried the build-compiler/generator-on-windows cmake along and started to put it into GHA. This was mostly pointless b/c past work shows the export produced by Windows doesn't produce correct integrals. I stopped and discarded the effort b/c even the GHA "checkout" errored on the Pople star basis set files. Possibly a filtered checkout could get around this.
2023-PR                             CURRENT-LIBTOOL         CURRENT-CMAKE
-------                             ---------------         -------------
tests/core/                         src/bin/profile/        src/bin/profile/ (no actual test)
tests/core/test.cc                  src/bin/libint/test.cc  src/bin/profile/ (test set up from profile; test.cc borrowed from ../libint/)
tests/eri/                          src/bin/test_eri/       src/bin/test_eri/ (no actual test)
src/lib/libint/tests/eri/           tests/eri/
src/lib/libint/tests/unit/          tests/unit/
src/lib/libint/tests/hartree-fock/  tests/hartree-fock/
src/lib/libint/tests/fortran/       export/fortran/

@loriab loriab force-pushed the generator branch 2 times, most recently from e049819 to 57fa38f Compare December 29, 2023 06:30
take 2

try 3

try 4

try 5

try 6

try 7

libint_maybe_unused

build src

split
@loriab loriab marked this pull request as ready for review December 29, 2023 18:52
@loriab loriab mentioned this pull request Jan 7, 2024
24 tasks
@evaleev evaleev force-pushed the generator branch 2 times, most recently from 077f2b6 to 0defc9d Compare October 13, 2025 13:29
@evaleev evaleev merged commit 5db6f29 into evaleev:master Oct 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants