Skip to content

Custom lang mapper regex and index#122

Merged
evenchange4 merged 4 commits intoevenchange4:masterfrom
camflan:master
Mar 13, 2018
Merged

Custom lang mapper regex and index#122
evenchange4 merged 4 commits intoevenchange4:masterfrom
camflan:master

Conversation

@camflan
Copy link
Contributor

@camflan camflan commented Feb 27, 2018

our legacy code uses a directory hierarchy that's incompatible with react-intl-po. This update allows users to customize the mapper pattern and the match index

@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #122   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines          59     62    +3     
  Branches        9     11    +2     
=====================================
+ Hits           59     62    +3
Impacted Files Coverage Δ
src/filterPOAndWriteTranslateSync.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34b421...b0293bb. Read the comment docs.

@camflan
Copy link
Contributor Author

camflan commented Feb 27, 2018

@evenchange4 Can you review when you get a chance?

@evenchange4 evenchange4 merged commit da9b079 into evenchange4:master Mar 13, 2018
@evenchange4
Copy link
Owner

@camflan Sorry for merge it so late, and I updated the document in the README.md file.
Thanks! Released v2.2.0 with your changes. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants