feat(fetch): process PDF content as markdown - #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fetchkit now converts text-based PDF responses to Markdown through a new ordered
ContentProcessorRegistry. The built-inPdfProcessoruses localpdf-inspectorprocessing, reports pages that need OCR, and keeps unsupported binary responses metadata-only.Custom callers can replace the processor registry while retaining all built-in URL fetchers.
Why
PDF handling was coupled to generic binary rejection, so useful document text could not reach LLM callers. URL fetchers are the wrong extension point because reliable PDF identification happens after the HTTP response.
Before / After
Before:
{"content_type":"application/pdf","error":"Binary content is not supported..."}After, from the CLI smoke test against the W3C dummy PDF:
{ "content_type": "application/pdf; qs=0.001", "format": "markdown", "content": "## Dummy PDF file\n", "metadata": {"extraction_method": "pdf_inspector"} }Risk
max_body_size, parsing runs off the async runtime, and concurrent PDF processing is capped at two documents. Parser-internal expansion remains documented as an accepted threat-model risk.pdf_requires_ocrand suggestuse_ocr.Checklist
Validation:
cargo fmt --all -- --check, workspace Clippy with warnings denied,cargo test --workspace, warning-free workspace docs, release build, live fetcher example, CLI PDF fetch, and MCP initialize/tools-list smoke.