refactor(svgs): extract embedded SVG strings to individual asset files#40
Merged
Merged
Conversation
Move nine SVG fragments from scripts/utils/svgs.ts into separate files under scripts/assets/svgs/ with snake_case names. Update svgs.ts to load them via fs.readFileSync at module load time. Closes #36. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/utils/svgs.tsinto individual files underscripts/assets/svgs/with snake_case names (e.g.peng→penguin.svg,githubCat→github_cat.svg,icons[0-3]→icon_followers.svgetc.)svgs.tsto load each asset viafs.readFileSyncat module load time — exported API is unchanged so no consumer updates neededTest plan
npm run typecheckpasses with no errorsnpm test)🤖 Generated with Claude Code