refactor(github): isolate GitHub domain into dedicated layer#42
Merged
Conversation
Extract all GitHub API concerns into scripts/github/ following a ports-and-adapters approach: shared HTTP client in githubApiClient.ts, GraphQL queries in queries.ts, and renamed fetchers (fetchUserStats, fetchUserLanguages) fixing the fetchUserData export name mismatch. Also fix Object.values() misuse on arrays and add request timeout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38.
Summary
scripts/github/domain folder with a ports-and-adapters structuregithubApiClient.ts(makeGraphQLRequest, buffer-based response handling, 30s timeout)queries.tsfetchUserData→fetchUserStatsandfetchLanguages#fetchUserData→fetchUserLanguages(fixing the export name mismatch)scripts/fetchers/directoryapi/stats.tsandapi/languages.tsTest plan
npm run typecheckpassesnpm testpasses/api/stats?username=<user>returns a valid SVG card/api/languages?username=<user>returns a valid SVG card🤖 Generated with Claude Code