refactor(renderers): deduplicate renderer code and centralize constants#43
Merged
Merged
Conversation
Extract shared TextAttr, CardAttr, and LanguageDataWithAccum interfaces to scripts/renderers/types.ts, move theme color magic strings to COLOR_SUBTLE / COLOR_LIGHT / COLOR_DARK constants in utils/constants.ts, and extract the two calcPercentages functions into scripts/renderers/calcPercentages.ts. Closes #39
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextAttr,CardAttr, andLanguageDataWithAccuminterfaces toscripts/renderers/types.tsCOLOR_SUBTLE,COLOR_LIGHT, andCOLOR_DARKconstants toscripts/utils/constants.ts, replacing hardcoded hex strings across all three rendererscalcPercentagesPieandcalcPercentagesBarintoscripts/renderers/calcPercentages.ts; update test imports accordinglyCloses #39
Test plan
npx tsc --noEmitpasses with no errorsnpx jest --no-coverage— all 18 tests pass🤖 Generated with Claude Code