Unregister and delete completed pods#346
Merged
Merged
Conversation
Signed-off-by: Lukas Hybner <git@hybner.net>
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 66.56% 65.48% -1.08%
==========================================
Files 3 3
Lines 299 307 +8
==========================================
+ Hits 199 201 +2
- Misses 74 80 +6
Partials 26 26
Continue to review full report at Codecov.
|
Signed-off-by: Lukas Hybner <git@hybner.net>
Collaborator
|
@lukashybner-ext90548 Can you try this tag:
|
Contributor
Author
|
I tried the tag v0.9.4-59-gcd45f46 and it works correctly. |
Collaborator
|
Thank you for the feedback and your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Actions has new feature - ephemeral runners. Which means that when workflow ends then pods end with completed status. So this changes is unregister and delete pods with completed status.