Change mock implementation to use store.KVStore instead of maps#146
Merged
tzdybal merged 13 commits intoevstack:mainfrom Oct 10, 2021
jbowen93:revert-2-revert-1-disk_storage_mock_DALC_134
Merged
Change mock implementation to use store.KVStore instead of maps#146tzdybal merged 13 commits intoevstack:mainfrom jbowen93:revert-2-revert-1-disk_storage_mock_DALC_134
tzdybal merged 13 commits intoevstack:mainfrom
jbowen93:revert-2-revert-1-disk_storage_mock_DALC_134
Conversation
Change mock implementation to use store.KVStore instead of maps
Revert "Disk storage mock dalc 134"
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 57.47% 57.07% -0.40%
==========================================
Files 24 24
Lines 1987 2127 +140
==========================================
+ Hits 1142 1214 +72
- Misses 729 786 +57
- Partials 116 127 +11
Continue to review full report at Codecov.
|
Contributor
Author
|
@tzdybal I don't see an option for me to assign a Reviewer so pinging you here. |
tzdybal
reviewed
Oct 9, 2021
tzdybal
reviewed
Oct 9, 2021
tzdybal
reviewed
Oct 9, 2021
Contributor
tzdybal
left a comment
tzdybal
left a comment
There was a problem hiding this comment.
Thanks for your submission!
This looks really good - I left some small comments.
…ve to package mock
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
tzdybal
pushed a commit
that referenced
this pull request
Oct 12, 2021
* update `MockDataAvailabilityLayerClient` to use `KVStore` instead of maps * ensure that `KVStore` is passed to `Init` in the tests Resolves #134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #134
Apologies for messed up commit history, need to make sure to squash before merging!