Skip to content

fix: golangci and markdown lint errors #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MSevey merged 1 commit into from
May 28, 2024
+14 −15
Merged

fix: golangci and markdown lint errors #1688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
run:
timeout: 5m
modules-download-mode: readonly
# mempool and indexer code is borrowed from Tendermint
skip-dirs:
- mempool
- state/indexer
- state/txindex
- third_party

linters:
enable:
Expand All @@ -27,6 +21,12 @@ linters:

issues:
exclude-use-default: false
# mempool and indexer code is borrowed from Tendermint
exclude-dirs:
- mempool
- state/indexer
- state/txindex
- third_party
include:
- EXC0012 # EXC0012 revive: Annoying issue about not having a comment. The rare codebase has such comments
- EXC0014 # EXC0014 revive: Annoying issue about not having a comment. The rare codebase has such comments
Expand Down
9 changes: 4 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ A modular framework for rollups, with an ABCI-compatible client interface. For m
<!-- markdownlint-enable MD013 -->

## Using Rollkit

### Rollkit CLI

The easiest way to use rollkit is via the rollkit CLI.
Expand Down Expand Up @@ -53,7 +54,6 @@ environments.

Check out our tutorials on our [website][docs].


## Contributing

We welcome your contributions! Everyone is welcome to contribute, whether it's
Expand Down Expand Up @@ -104,10 +104,9 @@ Graph](https://github.com/rollkit/rollkit/blob/main/specs/src/specs/rollkit-depe

## Audits

| Date | Auditor | Version | Report |
|------------|-----------------------------------------------|-------------------------------------------------------------------------------------|---------------------------------------------------------|
| 2024/01/12 | [Informal Systems](https://informal.systems/) | [eccdd...bcb9d](https://github.com/rollkit/rollkit/commit/eccdd0f1793a5ac532011ef4d896de9e0d8bcb9d) | [informal-systems.pdf](specs/audit/informal-systems.pdf) |
| Date | Auditor | Version | Report |
|---|---|---|---|
| 2024/01/12 | [Informal Systems](https://informal.systems/) | [eccdd...bcb9d](https://github.com/rollkit/rollkit/commit/eccdd0f1793a5ac532011ef4d896de9e0d8bcb9d) | [informal-systems.pdf](specs/audit/informal-systems.pdf) |
| 2024/01/10 | [Binary Builders](https://binary.builders/) | [eccdd...bcb9d](https://github.com/rollkit/rollkit/commit/eccdd0f1793a5ac532011ef4d896de9e0d8bcb9d) | [binary-builders.pdf](specs/audit/binary-builders.pdf) |


[docs]: https://rollkit.dev
8 changes: 4 additions & 4 deletions cmd/rollkit/commands/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ var VersionCmd = &cobra.Command{
return errors.New("version not set")
}
w := tabwriter.NewWriter(os.Stdout, 2, 0, 2, ' ', 0)
fmt.Fprintf(w, "\nrollkit version:\t%v\n", Version)
fmt.Fprintf(w, "rollkit git sha:\t%v\n", GitSHA)
fmt.Fprintln(w, "")
return w.Flush()
_, err1 := fmt.Fprintf(w, "\nrollkit version:\t%v\n", Version)
_, err2 := fmt.Fprintf(w, "rollkit git sha:\t%v\n", GitSHA)
_, err3 := fmt.Fprintln(w, "")
return errors.Join(err1, err2, err3, w.Flush())
},
}