Skip to content

Commit f1abb80

Browse files
committed
πŸ™ github: Replace firebase-deployment action (#26)
Replace firebase-deployment action by hand-crafted make targets. This has been motivated by an apparently broken firebase-tools release (4 hours old) that cannot be down-graded when using the firebase GitHub action and is a blocker. Aside: the foxygoat authors believe it is nice to stay third-party GitHub action free where possible so that the bulk of what's run on CI can also be run locally. While at it upgrade the firebase CLI version to the second most recent one - firebase-11.13.0 works, but the previous firebase-11.6.0 and the even more recent firebase-11.14.0 do not it seems. This merges the following commits: * hermit: Upgrade firebase version * github: Replace firebase-deployment action .github/workflows/cicd.yaml | 6 ++++++ .github/workflows/firebase-hosting-merge.yml | 17 ----------------- .../workflows/firebase-hosting-pull-request.yml | 15 --------------- Makefile | 5 +++-- ...irebase-11.6.0.pkg => .firebase-11.13.0.pkg} | 0 bin/firebase | 2 +- 6 files changed, 10 insertions(+), 35 deletions(-) Pull-Request: #26
2 parents 9f1c570 + c9105d5 commit f1abb80

File tree

6 files changed

+10
-35
lines changed

6 files changed

+10
-35
lines changed

β€Ž.github/workflows/cicd.yamlβ€Ž

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ jobs:
1111
steps:
1212
- uses: actions/checkout@v2
1313
- run: ./bin/make ci
14+
- run: ./bin/make firebase-deploy
15+
env:
16+
FIREBASE_SERVICE_ACCOUNT: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_EVY_LANG }}
1417

1518
release:
1619
runs-on: ubuntu-latest
@@ -22,3 +25,6 @@ jobs:
2225
- run: ./bin/make release
2326
env:
2427
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
28+
- run: ./bin/make firebase-deploy-prod
29+
env:
30+
FIREBASE_SERVICE_ACCOUNT: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_EVY_LANG }}

β€Ž.github/workflows/firebase-hosting-merge.ymlβ€Ž

Lines changed: 0 additions & 17 deletions
This file was deleted.

β€Ž.github/workflows/firebase-hosting-pull-request.ymlβ€Ž

Lines changed: 0 additions & 15 deletions
This file was deleted.

β€ŽMakefileβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,13 @@ frontend-serve: frontend ## Build frontend and serve on free port
8686

8787
# --- firebase -----------------------------------------------------------------
8888
CHANNEL ?= dev
89+
AUTH_CI = $(if $(CI), { printenv FIREBASE_SERVICE_ACCOUNT > out/gac.json; export GOOGLE_APPLICATION_CREDENTIALS=out/gac.json; };)
8990

9091
firebase-deploy-prod: firebase-public ## Deploy to live channel on firebase, use with care!
91-
firebase --config firebase/firebase.json deploy
92+
$(AUTH_CI) firebase --config firebase/firebase.json deploy
9293

9394
firebase-deploy: firebase-public ## Deploy to dev (or other) channel on firebase
94-
firebase --config firebase/firebase.json hosting:channel:deploy $(CHANNEL)
95+
$(AUTH_CI) firebase --config firebase/firebase.json hosting:channel:deploy $(CHANNEL)
9596

9697
firebase-emulate: firebase-public ## Run firebase emulator for auth, hosting and datastore
9798
firebase --config firebase/firebase.json emulators:start

β€Žbin/firebaseβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
.firebase-11.6.0.pkg
1+
.firebase-11.13.0.pkg

0 commit comments

Comments
Β (0)