github: Replace firebase-deployment action#26
Merged
juliaogris merged 2 commits intomasterfrom Oct 6, 2022
Merged
Conversation
Upgrade firebase version in hope to unbreak CI. `make firebase-deploy` to dev channel also failed locally (randomly, it didn't do that before). With the update it doesn't so 🤞.
juliaogris
force-pushed
the
firebase-deployment
branch
from
2fa0f95 to
9ca3dd2
Compare
Replace firebase-deployment action by hand-crafted make targets. This has been motivated by an apparently broken firebase-tools release (4 hours old) that cannot be down-graded when using the firebase GitHub action and is a blocker. Aside: the foxygoat authors believe it is nice to stay third-party GitHub action free where possible so that the bulk of what's run on CI can also be run locally.
juliaogris
force-pushed
the
firebase-deployment
branch
from
9ca3dd2 to
c9105d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace firebase-deployment action by hand-crafted make targets. This
has been motivated by an apparently broken firebase-tools release
(4 hours old) that cannot be down-graded when using the firebase GitHub
action and is a blocker. Aside: the foxygoat authors believe it is nice
to stay third-party GitHub action free where possible so that the bulk
of what's run on CI can also be run locally.
While at it upgrade the firebase CLI version to the second most recent
one - firebase-11.13.0 works, but the previous firebase-11.6.0 and the
even more recent firebase-11.14.0 do not it seems.