Skip to content

README: Document geth releases - #96

Merged
axic merged 2 commits into
masterfrom
readme-geth-releases
Nov 14, 2018
Merged

README: Document geth releases#96
axic merged 2 commits into
masterfrom
readme-geth-releases

Conversation

@chfast

@chfast chfast commented Nov 6, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@lrettig

lrettig commented Nov 7, 2018

Copy link
Copy Markdown
Member

Hi @chfast, thanks for helping improve this doc. To me, the format of this doc is a simple step by step "to do" checklist for people who want to connect to the testnet but don't necessarily know anything about geth or the other tooling. It seems like this change isn't a clear list of steps, but rather some information on the current state of EVMC support in geth, so I wonder if this is the best place for this information to live. Maybe we should put it into a separate doc?

@chfast

chfast commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator Author

My goal is to have a precise information how to build geth for testnet and what version is deployed on the testnet. It does not fit EVMC completely because there are additional changes added to geth that are not EVMC related.

@lrettig

lrettig commented Nov 7, 2018

Copy link
Copy Markdown
Member

It's not clear to me from this how I would build geth for testnet. It's a list of branches/PRs, not a list of steps. Sorry if I'm missing something obvious!

@chfast

chfast commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator Author

This describes what to build, but it's mostly for coordination with @jwasinger and @cdetrio. How to build it is in the next section.

I'm open for suggestions how to improve it and where to move it.

Comment thread README.md Outdated
Comment thread README.md
@lrettig

lrettig commented Nov 13, 2018

Copy link
Copy Markdown
Member

What's the most recent "bundle"? Is it https://github.com/ewasm/go-ethereum/releases/tag/ewasm-v3?

@chfast

chfast commented Nov 13, 2018

Copy link
Copy Markdown
Collaborator Author

Yes.

@chfast

chfast commented Nov 13, 2018

Copy link
Copy Markdown
Collaborator Author

I don't want to list the features we added. Is there any valuable information here you want to keep?

@lrettig
lrettig force-pushed the readme-geth-releases branch from 0a5aedc to 21f6589 Compare November 13, 2018 19:55
@axic

axic commented Nov 13, 2018

Copy link
Copy Markdown
Member

Needs to be rebased.

@chfast
chfast force-pushed the readme-geth-releases branch from 21f6589 to 0e66915 Compare November 13, 2018 20:59
@chfast

chfast commented Nov 13, 2018

Copy link
Copy Markdown
Collaborator Author

Review this again.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@axic
axic force-pushed the readme-geth-releases branch 4 times, most recently from d0a44ab to cc5b858 Compare November 14, 2018 00:30
Comment thread README.md Outdated
Adds latest tag name, which will go live tomorrow
Update commandline args per #94
@axic
axic force-pushed the readme-geth-releases branch from cc5b858 to 4e52287 Compare November 14, 2018 00:54
@axic
axic merged commit ccb1c8c into master Nov 14, 2018
@axic
axic deleted the readme-geth-releases branch November 14, 2018 00:55
@axic axic mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants