Skip to content
This repository was archived by the owner on Jun 11, 2019. It is now read-only.

mysql: fix test for future parser. #65

Merged
alvagante merged 2 commits into from
Sep 29, 2015
Merged

mysql: fix test for future parser. #65

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d52e47a
mysql: fix test for future parser.
gwarf Sep 25, 2015
5773c7d
mysql: address Alessandro comments on conditionals for future parser-…
gwarf Sep 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
}

# The whole mysql configuration directory can be recursively overriden
if $mysql::source_dir {
if $mysql::source_dir != '' {
Copy link
Member

@alvagante alvagante Sep 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change these conditionals to :
if $mysql::source_dir and $mysql::source_dir != '' {

so that nothing is done if the value is false (boolean)

file { 'mysql.dir':
ensure => directory,
path => $mysql::config_dir,
Expand All @@ -439,7 +439,7 @@


### Include custom class if $my_class is set
if $mysql::my_class {
if $mysql::my_class != '' {
include $mysql::my_class
}

Expand Down