feat(ui): redesign filter popovers for compact, consistent styling#2261
Merged
Conversation
…anagement
- Fix scrollbar shift when detail panel opens by moving scroll ownership
from html to the content area div (html overflow:hidden + scrollbar-gutter-stable)
- Add Page Up/Down keyboard navigation to command palette
- Fix command palette item sticking by wrapping results in {#key} block
- Style detail sheet headers (text-2xl, semibold, tracking-tight)
- Extract column management into dedicated two-panel dialog
- Add green gradient accent to stack card
- Simplify navbar padding and gap classes
- Left-align faceted filter action buttons and remove redundant Close button
- Remove dynamic 'Details' children from sidebar navigation routes
- Clean up dead column drag/toggle code from saved-view-picker
# Conflicts: # src/Exceptionless.Web/ClientApp/src/lib/features/saved-views/components/saved-view-picker.svelte
Multi-select, drop-down, and boolean filters now apply instantly when a value is selected instead of waiting for the popover to close. Escape still reverts to the previous state. Text-based filters (keyword, string, number) remain apply-on-close since typing requires completion.
The builder's filterChanged was clearing lastOpenFilterId which forced the popover closed whenever a filter value changed. Since filters now apply immediately, the popover should stay open.
…2260) * feat: apply filters immediately and keep popover open during selection - Change faceted-filter-builder to use \.pre with facet reuse, preserving open state across reactive filter updates - Replace page.url.searchParams checks with direct queryParams reads to eliminate double data-fetch caused by 200ms URL debounce - Prevent onFocusOutside from closing filter popovers - Add isNew pattern in onFilterChanged to avoid reassigning filters for existing (mutated-in-place) filter updates - Remove dead filterCacheVersion and unused applyAndClose functions * feat(ui): redesign filter popovers for compact, consistent styling - Replace text action buttons with icon buttons + tooltips - Redesign date range picker from tabbed 420px to compact flat list - Add padding around text/keyword/number filter inputs - Add spellcheck=false to keyword filter input - Update filter builder footer to use icon buttons - Clean up unused quickRanges prop from date picker * style: tighten sidebar org switcher spacing
…less/Exceptionless into predefined-saved-views
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Merges the filter popover redesign from PR #2260 (which was accidentally targeted at
predefined-saved-viewsinstead ofmain).spellcheck="false"Why
PR #2260 targeted
predefined-saved-viewsas the base branch instead ofmain.