Skip to content

Update hidden filter toggle tooltip #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejsmith merged 1 commit into from
Jun 5, 2026
+5 −2
Merged

Update hidden filter toggle tooltip #2298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...ClientApp/src/lib/features/shared/components/faceted-filter/faceted-filter-builder.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@

const hiddenFilterCount = $derived(filters.filter((filter) => filter.hidden).length);
const hiddenFilterLabel = $derived(`${hiddenFilterCount} Hidden ${hiddenFilterCount === 1 ? 'Filter' : 'Filters'}`);
const hiddenFilterToggleLabel = $derived(
`${showHiddenFilters ? 'Hide' : 'Show'} ${hiddenFilterCount} hidden ${hiddenFilterCount === 1 ? 'filter' : 'filters'}`
);
const hasFilters = $derived(filters.length > 0);
const visibleFacets = $derived(facets.filter((facet) => !facet.filter.hidden || showHiddenFilters));

Expand Down Expand Up @@ -272,7 +275,7 @@
variant="ghost"
size="icon-sm"
onclick={toggleHiddenFilters}
aria-label={`Toggle hidden filters. ${hiddenFilterLabel}.`}
aria-label={hiddenFilterToggleLabel}
>
{#if showHiddenFilters}
<EyeOff class="text-muted-foreground size-4" />
Expand All @@ -289,7 +292,7 @@
</Button>
{/snippet}
</Tooltip.Trigger>
<Tooltip.Content>Toggle hidden filters</Tooltip.Content>
<Tooltip.Content>{hiddenFilterToggleLabel}</Tooltip.Content>
</Tooltip.Root>
{/if}
{#if filters.some((f) => f.type !== 'date')}
Expand Down