Skip to content

⬆️ UPDATE: myst-parser~=0.13.1#284

Merged
chrisjsewell merged 5 commits into
masterfrom
update-mdit
Dec 31, 2020
Merged

⬆️ UPDATE: myst-parser~=0.13.1#284
chrisjsewell merged 5 commits into
masterfrom
update-mdit

Conversation

@chrisjsewell

@chrisjsewell chrisjsewell commented Dec 18, 2020

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Dec 20, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #284 (bcce18c) into master (9fddd23) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          12       12           
  Lines        1316     1316           
=======================================
  Hits         1152     1152           
  Misses        164      164
Flag Coverage Δ
pytests 87.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/__init__.py 87.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fddd23...bcce18c. Read the comment docs.

@chrisjsewell chrisjsewell changed the title update ⬆️ UPDATE: myst-parser~=0.13.0 Dec 21, 2020
choldgraf
choldgraf reviewed Dec 29, 2020
View reviewed changes

@choldgraf choldgraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow turnaround, the holidays got my to-do list all messed up. This looks good to me w/ one comment about the Jupytext version. I'm not sure why there are suddenly errors popping up on the execution tests though :-/

https://github.com/executablebooks/MyST-NB/pull/284/checks?check_run_id=1586245248#step:5:36

Comment thread setup.py Outdated
],
"rtd": [
"jupytext>=1.6.0",
"jupytext-ebp==1.7.2a0", # TODO waiting for jupytext 1.7.2 release

@choldgraf choldgraf Dec 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now out but it is 1.8.0: https://github.com/mwouts/jupytext/releases/tag/v1.8.0

@chrisjsewell chrisjsewell Dec 29, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeh I know 👍 jupytext/jupytext#692

@chrisjsewell chrisjsewell changed the title ⬆️ UPDATE: myst-parser~=0.13.0 ⬆️ UPDATE: myst-parser~=0.13.1 Dec 31, 2020
@chrisjsewell
chrisjsewell merged commit 541a110 into master Dec 31, 2020
@chrisjsewell
chrisjsewell deleted the update-mdit branch December 31, 2020 10:41
@choldgraf

choldgraf commented Dec 31, 2020

Copy link
Copy Markdown
Member

🎉

chrisjsewell added a commit that referenced this pull request Jan 12, 2021
@chrisjsewell
⬆️ UPDATE: myst-parser~=0.13.1 (#284)
cf59e74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choldgraf choldgraf choldgraf left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisjsewell @choldgraf