Skip to content

Better early return for add_launch_buttons if no launch buttons #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choldgraf merged 1 commit into from
Feb 26, 2023
Merged

Better early return for add_launch_buttons if no launch buttons #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sphinx_book_theme/header_buttons/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ def add_launch_buttons(
# If so, insert the URLs depending on the configuration
config_theme = app.config["html_theme_options"]
launch_buttons = config_theme.get("launch_buttons", {})
if not launch_buttons or not _is_notebook(app, pagename):
if (
not launch_buttons
or not _is_notebook(app, pagename)
or not any(
launch_buttons[key]

@choldgraf choldgraf Feb 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt we use launch_buttons.get(key) in case one is not present so we don't raise a key error?

for key in ("binderhub_url", "jupyterhub_url", "thebe", "colab_url")
)
):
return

# Grab the header buttons from context as it should already exist.
Expand Down