🧪 Fix dead codecov upload, modernize CI actions#272
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 87.87% 88.08% +0.21%
==========================================
Files 11 11
Lines 1031 1041 +10
==========================================
+ Hits 906 917 +11
+ Misses 125 124 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Codecov upload step's condition still required matrix.python-version == '3.9', which left the test matrix in #250, so coverage has been silently dead (never uploaded) since then. Re-key the condition to the py3.13 / Sphinx ~=8.0 / ubuntu-latest cell, and allow it to fire on pushes to main as well as same-repo PRs. Also: - Bump codecov/codecov-action v3 -> v5 (deprecated), renaming the `file:` input to `files:` per the v4+ API. - Add a top-level concurrency group keyed on workflow + ref with cancel-in-progress, so superseded pushes stop wasting runners. - Bump actions/checkout v4 -> v5 and actions/setup-python v5 -> v6 in all jobs.
chrisjsewell
force-pushed
the
brief/05-ci-modernization
branch
from
ebb79b3 to
4aef972
Compare
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage upload has been silently dead since #250: the condition still checked
matrix.python-version == '3.9', which left the matrix. Part of #265 (Phase 1).~=8.0+ ubuntu), for same-repo PRs and pushes to main (fork PRs excluded as before — they lack the token).codecov/codecov-actionv3 → v5 (file:→files:; token/flags/fail_ci_if_error preserved).concurrencygroup cancelling superseded runs per ref.actions/checkout→ v5,actions/setup-python→ v6 across all jobs.First run on this PR should show the Codecov step actually executing; the first upload after the long gap may show a large coverage delta on codecov.io.