Skip to content

[ENH] Patch translations - #42

Closed
vincentxavier wants to merge 13 commits into
executablebooks:mainfrom
vincentxavier:patch-translations
Closed

[ENH] Patch translations#42
vincentxavier wants to merge 13 commits into
executablebooks:mainfrom
vincentxavier:patch-translations

Conversation

@vincentxavier

Copy link
Copy Markdown

I've made this work for Sphinx-proof, and the patch should also apply here.

This is related to #13

Currently, this patch only contains french translations.

Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
@welcome

welcome Bot commented Dec 5, 2021

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@vincentxavier vincentxavier changed the title Patch translations [ENH] Patch translations Dec 5, 2021
@vincentxavier
vincentxavier marked this pull request as draft December 5, 2021 20:58
@mmcky

mmcky commented Dec 6, 2021

Copy link
Copy Markdown
Member

Thanks @vincentxavier. I am about to merge #37 which is a pretty extensive rewrite of this package (with the aim to make it more maintainable over the long term) and use more sphinx internals. It is passing all test cases with some minor changes to the title styles. Would love to work with you to fix up #42 once this is merged.

@vincentxavier

vincentxavier commented Dec 6, 2021 via email

Copy link
Copy Markdown
Author

Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
@mmcky

mmcky commented Apr 1, 2022

Copy link
Copy Markdown
Member

@vincentxavier I saw that you had made some commits so I have enabled the CI to run for you.

Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
Signed-off-by: Vincent-Xavier JUMEL <vincent-xavier.jumel@ac-paris.fr>
@mmcky

mmcky commented Oct 21, 2025

Copy link
Copy Markdown
Member

Again thanks for your work on this @vincentxavier -- we are working on upgrades to internationalisation (see #75). These updates should be released soon.

@mmcky mmcky closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants