fix: distinguish Author URI from Plugin URI#36
Merged
Conversation
Contributor
Test in WordPress PlaygroundTest the plugin with the code from this branch:
|
Plugin Check flagged identical Plugin URI and Author URI headers. Point Author URI to https://exelearning.net/ while keeping Plugin URI on the GitHub repo, and update translation catalogs so the new msgid passes check-untranslated. Partially addresses exelearning/exelearning#1542.
erseco
force-pushed
the
fix/distinct-author-uri
branch
from
2382ee9 to
2e9aa0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin Check reports that Plugin URI and Author URI must not be identical. Point Author URI to https://exelearning.net/ while keeping Plugin URI on the GitHub repo.
Partially addresses exelearning/exelearning#1542 (one of the Plugin Check findings).
Test plan