Add analyzer feedback for Annalyns Infiltration

[kahgoh]

pull request

closes #2669

---

Reviewer Resources:

Track Policies

[manumafe98]

Checking on the Javascript analyzer approach I would say that we could be more explicit on some actionables, I like the topics already created, but maybe we could add a couple more, I also would like your opinion on this one @sanderploegsma

The if statement in the method seem to be treated as essential as well, check this

[sanderploegsma]

I think that given the scope of the concept and the exercise, we should steer students towards a solution that only uses boolean operators (&&, || and !). If a solution uses if-statements, ternary expressions or comparison operators and boolean literals, I think the analyzer comments should be of type essential.

In terms of additional comments, I can think of only one thing, and that is unnecessary parentheses in the final method. If there is a consistent way to check this, could be an informative comment if the rest of the solution doesn't receive any feedback.

[kahgoh]

Making them essential sounds good to me ;)

Thanks for pointing me to the Javascript analyzer @manumafe98. I've tried taking some inspiration from there for the wording and added something about the unnecessary parentheses.

[manumafe98]

Thanks for pointing me to the Javascript analyzer @manumafe98. I've tried taking some inspiration from there for the wording and added something about the unnecessary parentheses.

Np! this is already looking great!