[build-tools] Add read app config and package.json functions #3585
Merged
[build-tools] Add read app config and package.json functions #3585
Conversation
0d7e5d1 to
6487637
Compare
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
==========================================
+ Coverage 54.80% 54.84% +0.04%
==========================================
Files 834 836 +2
Lines 35855 35886 +31
Branches 7487 7488 +1
==========================================
+ Hits 19648 19679 +31
Misses 16112 16112
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EvanBacon
reviewed
Apr 9, 2026
| fn: async (stepCtx, { env }) => { | ||
| const metadata = stepCtx.global.staticContext.metadata as Metadata | undefined; | ||
| const appConfig = ( | ||
| await readAppConfig({ |
Contributor
There was a problem hiding this comment.
Same as npx expo config --type public --json
Contributor
Author
There was a problem hiding this comment.
Thanks for the early feedback @EvanBacon — I ended up using readAppConfig here because it handles SDK-version differences and includes some resiliency/fallback behavior. If you’d prefer the simpler path, I can switch this to a direct CLI call. Thoughts?
c92d958 to
85af270
Compare
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
approved these changes
Apr 10, 2026
Add new eas/read_package_json and eas/read_app_config workflow functions and register them so fingerprint jobs can log project metadata consistently with build setup. # Conflicts: # CHANGELOG.md
Move the fingerprint workflow read-step entry from Bug fixes to New features in the main changelog section. # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
…p fields Avoid failing build steps when app config or package.json cannot be read, and expose app name/slug/version from read_app_config output with test coverage for success and failure paths.
# Conflicts: # CHANGELOG.md
Deduplicate package.json read-and-log behavior between setup and readPackageJson step so both paths stay in sync, and add focused test coverage for the shared helper.
Switch the readAppConfig step to emit a single serialized app_config output and update unit tests to assert the new output shape.
# Conflicts: # CHANGELOG.md
02fc0b9 to
d94cb76
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Needing to add this information in the fingerprint job and thought about creating reusable steps that we can add into others as needed.
Ref ENG-20510
How
Creating 2 new functions that reuse existing utils functions to leverage SDK check and standard error messages.
Export app config basic values so devs can leverage it to get slug, name and version.
Test Plan
yarn buildprocess-compose upyarn start:docker(impersonate staging first)yarn start:localEXPO_LOCAL=1 npx eas-cli@latest workflow:run fingerprint-test.ymlonProduced the Following





readPackageJsonandreadAppConfig(since uploading invalid ones weren't possible with the cli). Result is the following (no job failure as expected; Error message will be accordingly to failure. Seeing `test due to manually introduced exception for that test):