Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
+ Coverage 54.86% 55.00% +0.15%
==========================================
Files 836 839 +3
Lines 35901 36000 +99
Branches 7492 7509 +17
==========================================
+ Hits 19694 19800 +106
+ Misses 16112 16105 -7
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5c6fd4a to
69a1359
Compare
69a1359 to
ab71dbc
Compare
|
Subscribed to pull request
Generated by CodeMention |
| BuildStepInput.createProvider({ | ||
| id: 'export_command', | ||
| allowedValueTypeName: BuildStepInputValueTypeName.STRING, | ||
| required: false, | ||
| defaultValue: 'npx expo export --platform web', | ||
| }), |
There was a problem hiding this comment.
wdyt about making it be a separate function? then the input to this function would be the export_dir and output of eas/[expo_]export would be the dist_dir?
There was a problem hiding this comment.
Great idea, allows a little more space for inputs from the export side. Let me know if you have any additional thoughts around the inputs of export function.
Around the name, not 100% sure if you suggested eas/expo_export, would that be the case? I can see prebuild which similarly, calls expo command, not having the prefix although it would make sense imo. export only could be too broad for people new to EAS, as me?
| }); | ||
| outputs.deploy_json.set(result.stdout.toString()); | ||
| } catch (error) { | ||
| throw new UserError( |
There was a problem hiding this comment.
i wonder if it would be nice if we made eas-cli deploy return different exit codes for different issues and based on that figure out whether it was a system or user error?
I have https://exponent-internal.slack.com/archives/C06EFBQK3B7/p1773417343042269 in my memory
Co-authored-by: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
…rkflows - Add eas/export: expo export via runExpoCliCommand and getExportCommand, structured inputs, export_dir output. - Refine eas/deploy: build argv with getDeployCommand, parse deploy JSON with parseDeploymentOutput, expanded tests. - Register eas/export in getEasFunctions; update CHANGELOG for both steps.
2ed7556 to
318e764
Compare
Probe easd --help when ENVIRONMENT is development; use easd if it succeeds, otherwise log and fall back to npx eas-cli@staging. Log when easd is used. Pass logger from easBuildInternal into resolver so messages appear in build logs.
Probe easd --help in development; on success log a warn and use easd. Fall back to npx eas-cli@staging without an info line. Pass logger from easBuildInternal and runEasCliCommand so the warn appears in logs.
101e6f1 to
f3bbb02
Compare
|
✅ Thank you for adding the changelog entry! |
Why
Introduce
eas/deployfunction to streamline export+deploy usual combination within single unit. Includesdeploy_jsonoutput fromeas deploy --jsonfor anything that comes after.Ref ENG-14737
How
New function with configurable export command, deploy alias, prod and source_maps; environment is passed through when it’s on job metadata.
Test Plan
Local run with the following workflows
✅ Success path
❌ Failure pattern