Skip to content

[worker] Use cache API for the legacy cache#3860

Open
sjchmiela wants to merge 3 commits into
mainfrom
stanley/turtle-build-cache-urls
Open

[worker] Use cache API for the legacy cache#3860
sjchmiela wants to merge 3 commits into
mainfrom
stanley/turtle-build-cache-urls

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

The legacy cache does not work in workflow-orchestration.

This rewrites the CacheManager to the new/not-so-new Turtle caches API.

Summary

  • replace worker build cache restore/save GCS config URLs with turtle cache download/upload helpers
  • derive stable build cache keys without mutating job.cache and preserve clear for force uploads
  • keep existing tar archive restore/save semantics and add CacheManager unit coverage

Test plan

  • cd packages/worker && yarn test CacheManager.test.ts
  • cd packages/worker && yarn typecheck
  • cd packages/build-tools && yarn typecheck
  • git diff --check

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela changed the title Use turtle URLs for build cache [worker] Use cache API for the legacy cache Jun 15, 2026
@sjchmiela sjchmiela force-pushed the stanley/turtle-build-cache-urls branch from 555d55f to e11ae03 Compare June 15, 2026 16:00
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.45%. Comparing base (f8c2b2d) to head (e11ae03).

Files with missing lines Patch % Lines
packages/worker/src/CacheManager.ts 92.60% 2 Missing ⚠️
...kages/build-tools/src/steps/functions/saveCache.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3860      +/-   ##
==========================================
+ Coverage   58.42%   58.45%   +0.04%     
==========================================
  Files         917      917              
  Lines       39978    39985       +7     
  Branches     8416     8416              
==========================================
+ Hits        23353    23370      +17     
+ Misses      16530    16520      -10     
  Partials       95       95              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela requested a review from AbbanMustafa June 18, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant