[eas-cli] share agent templates from llm-configs#3865
Conversation
|
Subscribed to pull request
Generated by CodeMention |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3865 +/- ##
==========================================
- Coverage 58.48% 58.45% -0.03%
==========================================
Files 919 922 +3
Lines 40115 40199 +84
Branches 8448 8462 +14
==========================================
+ Hits 23458 23493 +35
- Misses 16561 16610 +49
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
side question: could we fetch the doc from github.com/expo/llm-configs/blob/main/expo-app/AGENTS.md directly? we could always get latest agents.md without publishing eas-cli |
|
There are drawbacks - it would make offline creation, GitHub outage, proxy issues, or timeout produce no agent files. IMHO project creation should not depend on GitHub raw being reachable, bundled fallback is the safer design. What do you think? |
|
that's a good point. in this case, how about to sync files in prepublish phase? we still fetch CLAUDE.md/AGENTS.md from llm_configs, and overwrites existing templates. some advantages for this approach:
|
|
✅ Thank you for adding the changelog entry! |
|
I like that approach! Updated the PR |
Syncs the generated app
AGENTS.mdandCLAUDE.mdtemplates fromexpo/llm-configsduring EAS CLIprepack, before the package is rebuilt for publishing. Keeps the synced templates bundled in EAS CLI soeas project:newstill works offline and does not add a runtime@expo/llm-configsdependency.Verified with
yarn workspace eas-cli sync-agent-templates, byte-for-byte comparison against the upstream raw files,yarn workspace eas-cli test src/commandUtils/new/__tests__/projectFiles.test.ts --runInBand,yarn workspace eas-cli typecheck-for-build, andyarn workspace eas-cli build. Previously also ran a localeas project:newsmoke test and confirmed generated agent files matched the shared templates.