Skip to content

[eas-cli] share agent templates from llm-configs#3865

Open
davidmokos wants to merge 3 commits into
mainfrom
davidmokos/share-agents-template
Open

[eas-cli] share agent templates from llm-configs#3865
davidmokos wants to merge 3 commits into
mainfrom
davidmokos/share-agents-template

Conversation

@davidmokos

@davidmokos davidmokos commented Jun 16, 2026

Copy link
Copy Markdown

Syncs the generated app AGENTS.md and CLAUDE.md templates from expo/llm-configs during EAS CLI prepack, before the package is rebuilt for publishing. Keeps the synced templates bundled in EAS CLI so eas project:new still works offline and does not add a runtime @expo/llm-configs dependency.

Verified with yarn workspace eas-cli sync-agent-templates, byte-for-byte comparison against the upstream raw files, yarn workspace eas-cli test src/commandUtils/new/__tests__/projectFiles.test.ts --runInBand, yarn workspace eas-cli typecheck-for-build, and yarn workspace eas-cli build. Previously also ran a local eas project:new smoke test and confirmed generated agent files matched the shared templates.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.45%. Comparing base (51aceb1) to head (62f3c48).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3865      +/-   ##
==========================================
- Coverage   58.48%   58.45%   -0.03%     
==========================================
  Files         919      922       +3     
  Lines       40115    40199      +84     
  Branches     8448     8462      +14     
==========================================
+ Hits        23458    23493      +35     
- Misses      16561    16610      +49     
  Partials       96       96              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidmokos davidmokos requested a review from Kudo June 16, 2026 13:07
@Kudo

Kudo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

side question: could we fetch the doc from github.com/expo/llm-configs/blob/main/expo-app/AGENTS.md directly? we could always get latest agents.md without publishing eas-cli

Copy link
Copy Markdown
Author

There are drawbacks - it would make offline creation, GitHub outage, proxy issues, or timeout produce no agent files. IMHO project creation should not depend on GitHub raw being reachable, bundled fallback is the safer design. What do you think?

Kudo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

that's a good point. in this case, how about to sync files in prepublish phase? we still fetch CLAUDE.md/AGENTS.md from llm_configs, and overwrites existing templates.

some advantages for this approach:

  • reduce llm_configs deps overhead. the repo may contain other files that are not used by eas-cli.
  • whenever we update to llm_configs, next time when eas-cli published, we get the latest one automatically.
  • still have offline support.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@davidmokos

davidmokos commented Jun 17, 2026

Copy link
Copy Markdown
Author

I like that approach! Updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants