[build-tools] add metadata to eas/upload_artifact#3878
Open
hSATAC wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hSATAC
force-pushed
the
ash/eng-19035-add-metadata-to-upload_artifact
branch
from
18be157 to
6c1441a
Compare
hSATAC
force-pushed
the
ash/eng-19036-upload-maestro-screenshots
branch
from
863bd75 to
5fe7e8d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ash/eng-19036-upload-maestro-screenshots #3878 +/- ##
============================================================================
+ Coverage 58.55% 58.55% +0.01%
============================================================================
Files 923 923
Lines 40332 40335 +3
Branches 8490 8492 +2
============================================================================
+ Hits 23611 23615 +4
+ Misses 16625 16624 -1
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
approved these changes
Jun 18, 2026
hSATAC
force-pushed
the
ash/eng-19035-add-metadata-to-upload_artifact
branch
from
6c1441a to
869e93e
Compare
hSATAC
force-pushed
the
ash/eng-19036-upload-maestro-screenshots
branch
from
5fe7e8d to
4c1cb19
Compare
hSATAC
force-pushed
the
ash/eng-19035-add-metadata-to-upload_artifact
branch
from
869e93e to
b1679ce
Compare
hSATAC
force-pushed
the
ash/eng-19036-upload-maestro-screenshots
branch
from
4c1cb19 to
173cd06
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The screen-recording deep-link feature (ENG-19035) uploads the recording via a www-generated
eas/upload_artifactworkflow step, and needs to attach{ kind: 'screen-recording', startedAtMs, device }metadata so the website can derive the jump-to-failure seek. The genericeas/upload_artifactstep had no way to pass metadata through.How
Add an optional
metadataJSONBuildStepInputtoeas/upload_artifactand forward it toctx.runtimeApi.uploadArtifact(the runtimeApi metadata passthrough already exists from the screenshots plan). Backward-compatible — existing callers that don't setmetadataare unaffected (it's optional;undefinedserializes as absent → no-op). Note: metadata is persisted only for generic artifacts; the worker's managed-type upload paths drop it.Test Plan
Unit tests (
uploadArtifact.test.ts):metadatais forwarded toruntimeApi.uploadArtifactwhen provided (generic artifact type), and omitted when absent. Passing in CI.