[linking] Polyfill for Linking.openSettings on iOS#7676
Merged
brentvatne merged 4 commits intomasterfrom Apr 7, 2020
Merged
Conversation
ide
approved these changes
Apr 6, 2020
Member
ide
left a comment
ide
left a comment
There was a problem hiding this comment.
Need to rebuild the JS files. Looks OK, I'd commit to master so we minimize branch-specific code. I'd like to just use expo-linking (new API) everywhere for stability eventually.
EvanBacon
reviewed
Apr 6, 2020
|
|
||
| // TODO: remove this on SDK 38 after adding to EXLinking | ||
| if (Platform.OS === 'ios') { | ||
| newLinking.openSettings = () => newLinking.openURL('app-settings:'); |
Member
Author
There was a problem hiding this comment.
yeah this is already implemented and works in expo client for android, we just didn't fix it on the ios side
brentvatne
force-pushed
the
@brent/linking-open-settings
branch
from
7ad390f to
b6c4750
Compare
brentvatne
added a commit
that referenced
this pull request
Apr 7, 2020
* [linking] Polyfill for Linking.openSettings on iOS * Update build files * [reat-native-lab] Point to sdk-37.0.1 * [templates] Update react-native dependency on managed templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#6786 (comment)
We may just want to keep this on the sdk-37 branch.
How
To-do
Test Plan
Call
Linking.openSettings()on iOS, should open settings