Skip to content

Big maintenance PR#1721

Merged
ariasuni merged 9 commits intomainfrom
update-deps
Mar 8, 2026
Merged

Big maintenance PR#1721
ariasuni merged 9 commits intomainfrom
update-deps

Conversation

@ariasuni
Copy link
Contributor

@ariasuni ariasuni commented Feb 18, 2026

  • palette v0.7.6 -> v0.7.5 and set the version to = so it can’t be upgraded by accident (see fix: implement again PR 1207 (temporarily downgrade palette dependency from v0.7.6 -> v0.7.5) #1680)
  • update crates, Rust version and flake.lock
  • fix a few Clippy warnings (very minor things)
  • clean global lint attributes and remove clippy::pedantic
  • chore: remove some leftover, unused code
  • chore: replace #[allow(unused)] by #[cfg(unix)] when appropriate
  • fix(ci): use secret GitHub token to avoid rate limiting when downloading Nix stuff
  • update to Rust edition 2024

Fix #1232

@ariasuni ariasuni force-pushed the update-deps branch 16 times, most recently from b824b11 to f3a968e Compare February 18, 2026 23:03
@ariasuni
Copy link
Contributor Author

ariasuni commented Feb 18, 2026

So uh I just wanted to remove some warnings (a lot of warnings cause errors due to how the CI is setup) and I went through a tunnel, so lots of improvements packed into a PR x)

@ariasuni ariasuni changed the title Downgrade palette crate, upgrade other dependencies and Rust version Big maintenance PR Feb 18, 2026
This time, set the version to `=0.7.5` to avoid accidental upgrades.

See commit b1abb0f and previous PR:
#1207 (comment)
- Update crates to avoid the CVE error in CI
- Update Rust to be able to update the crate with a CVE
  (Rust 1.90: highest supported by OpenBSD right now)
- Update flake.lock to be able to use Rust 1.90 in the CI
Biggest change is splitting platform-specific code from permissions.rs
(similarly to flags.rs in the same directory).
We can hit rate limiting when downloading Nix stuff, e.g.:

```
error: Failed to open archive (Source threw exception: error:
        … during download of 'https://api.github.com/repos/numtide/flake-utils/tarball/11707dc2f618dd54ca8739b309ec4fc024de578b'

        error: unable to download 'https://api.github.com/repos/numtide/flake-utils/tarball/11707dc2f618dd54ca8739b309ec4fc024de578b': HTTP error 401

        response body:

        {
          "message": "Bad credentials",
          "documentation_url": "https://docs.github.com/rest",
          "status": "401"
        })
```
Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks fine to me! ... Just one question, see below.

@ariasuni ariasuni enabled auto-merge (rebase) March 6, 2026 13:48
@ariasuni ariasuni disabled auto-merge March 6, 2026 13:48
Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good still! Thanks!

@ariasuni ariasuni merged commit 744d166 into main Mar 8, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

downgrade palette: "so I think I accidentally updated it again 🤦‍♀️"

2 participants