Merged
Conversation
b824b11 to
f3a968e
Compare
Contributor
Author
|
So uh I just wanted to remove some warnings (a lot of warnings cause errors due to how the CI is setup) and I went through a tunnel, so lots of improvements packed into a PR x) |
palette crate, upgrade other dependencies and Rust versionThis time, set the version to `=0.7.5` to avoid accidental upgrades. See commit b1abb0f and previous PR: #1207 (comment)
f3a968e to
c70cfa7
Compare
- Update crates to avoid the CVE error in CI - Update Rust to be able to update the crate with a CVE (Rust 1.90: highest supported by OpenBSD right now) - Update flake.lock to be able to use Rust 1.90 in the CI
Biggest change is splitting platform-specific code from permissions.rs (similarly to flags.rs in the same directory).
c70cfa7 to
1d24bce
Compare
We can hit rate limiting when downloading Nix stuff, e.g.:
```
error: Failed to open archive (Source threw exception: error:
… during download of 'https://api.github.com/repos/numtide/flake-utils/tarball/11707dc2f618dd54ca8739b309ec4fc024de578b'
error: unable to download 'https://api.github.com/repos/numtide/flake-utils/tarball/11707dc2f618dd54ca8739b309ec4fc024de578b': HTTP error 401
response body:
{
"message": "Bad credentials",
"documentation_url": "https://docs.github.com/rest",
"status": "401"
})
```
1d24bce to
d0256da
Compare
gierens
reviewed
Mar 4, 2026
Member
gierens
left a comment
There was a problem hiding this comment.
Overall, looks fine to me! ... Just one question, see below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
=so it can’t be upgraded by accident (see fix: implement again PR 1207 (temporarily downgrade palette dependency from v0.7.6 -> v0.7.5) #1680)clippy::pedanticFix #1232