Set window width to account for minimum width required for visible rollups#1507
Merged
f4exb merged 1 commit intof4exb:masterfrom Nov 8, 2022
Merged
Set window width to account for minimum width required for visible rollups#1507f4exb merged 1 commit intof4exb:masterfrom
f4exb merged 1 commit intof4exb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates RollupContents to calculate and set the minimum width required for the visible widgets.
The window resize in onWidgetRolled in channels and features has been updated to take this into account, so that the window should resize to respect the minimum size when a widget is rolled up/down.
As such, a few places where I'd hacked this in with hardcoded constants have been removed.
The practical result of this, is that a channel such as the Broadcast FM Demod, can be made a bit smaller when the RDS Rollup is not visible.