Merged
Conversation
…for GPS positioning.
Owner
|
Hello and Happy New Year! It is fine for me to use QFile in place of istream and simplify the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An assortment of changes for Android.
Main one for you to review is probably the changes to the File Input plugin. Android has strange permissions model for accessing user storage, that requires use of URLs. QFile supports this, but istream doesn't, so had to change the I/O functions to use QFile. Currently this is done via #defines, but QFile code could just be used on all platforms. Let me know if you want me to simplify this.