Merged
Conversation
…on. Fix a couple of bugs.
f4exb
reviewed
Apr 10, 2024
sdrbench/CMakeLists.txt
Outdated
| test_ft8.cpp | ||
| test_callsign.cpp | ||
| test_ft8protocols.cpp | ||
| ../ft8/pack0.cpp |
Owner
There was a problem hiding this comment.
This should not be added here. It is part of the FT8 library see set(sdrbench_FT8_LIB ft8) above...
Edit: I am wondering why you had an issue with Windows here since the CI/CD with the initial changes went fine: https://github.com/f4exb/sdrangel/actions/runs/8594560974
Collaborator
Author
There was a problem hiding this comment.
Have removed it, as doesn't seem to be needed now. I added it when you made the first FT8 related commit - maybe something has changed since then or was just a dodgy build that made it look like it was needed when it wasn't.
Owner
There was a problem hiding this comment.
Yes indeed there was a failing build that I corrected in a later commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Radiosonde: Support feeding data to SondeHub. Improve humidity calculation. A few small bug fixes.
RemoteTCPInput: Fix channel marker.
Preset: Copy and initialise all fields. Fix for #2061
sdrbench: Fix compilation on Windows.