Merged
Conversation
Fixes the 5 includes that are different from the majority:
grep -Ehr "#include .+dsptypes" --include=*.h | sort | uniq -c
110 #include "dsp/dsptypes.h"
1 #include <dsp/dsptypes.h>
4 #include "dsptypes.h"
Fixes the 5 includes that are different from the majority:
grep -Ehr "#include .+export" --include=*.h | sort | uniq -c
769 #include "export.h"
5 #include "../../exports/export.h"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
export.hand fordsptypes.hthat were different from the restFor point 1 there are more includes that could be "canonalized", but since the projects compile anyway, I'm not changing any more path for the moment.
For point 2 I removed the includes only from the files I could compile, but I'm still missing some optional libraries so there may be more. And are already too many...
For point 3 I tried move includes around this as little as possible since those are mostly private includes.
For point 4 there where only a handful of files so I did them even if they were compiling fine.
I compiled this under Linux and I will look for any failure of the CI for Windows/Mac and fix them.