Don't call start() in demod constructors#2104
Merged
f4exb merged 5 commits intof4exb:masterfrom May 10, 2024
Merged
Conversation
SSDDemodGUI: Disable AGC widgets when AGC disabled.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the call to start() in the AM, NFM, WFM, BFM, VOR and SSB demods, to fix #2102
The BFM demod also has additional changes so that the baseband and sink are deleted on stop() to ensure the destructor is called disconnecting the audio sink, and brings the code structure in-line with the other demods.
There are a few changes to the NFM, BFM and SSB demod GUI code to account for the baseband/sink not existing all the time.
Also, there's an unrelated change to the SSB GUI that disables AGC settings when AGC is disabled.
Note that the DSDDemod, M17Demod and FreeDVDemod probably also need the change, but let me know if there's any problems with the patch so far.