updated FCS to latest#1122
Conversation
| | FSharpInlineAnnotation.OptionalInline -> false | ||
| | FSharpInlineAnnotation.PseudoValue | ||
| | FSharpInlineAnnotation.AlwaysInline -> true | ||
| | FSharpInlineAnnotation.AggressiveInline -> failwith "Not Implemented" |
There was a problem hiding this comment.
I guess we can consider this Inline as well
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="FSharp.Core" Version="4.2.1" /> | ||
| <PackageReference Include="FSharp.Core" Version="4.2.3" /> |
There was a problem hiding this comment.
I was trying to reduce a bit the requirement for libraries depending on Fable.Core, but I guess it doesn't make too much of a difference :)
| let makeProjectOptions project sources otherOptions = | ||
| { ProjectFileName = project | ||
| ProjectFileNames = sources | ||
| SourceFiles = sources |
There was a problem hiding this comment.
This is probably the best API change of all ;)
| | None -> | ||
| return! loop checker state | ||
| } | ||
| let checker = FSharpChecker.Create(keepAssemblyContents=true, msbuildEnabled=false) |
There was a problem hiding this comment.
So this is not needed now? I don't remember why we had to add it, probably for the .fsx scripts. Which I've disabled temporarily btw, as Fable uses now Dotnet.ProjInfo to crack the .fsproj files and I didn't have time to fix it for scripts yet (I think most people use .fsproj now anyways).
| OriginalLoadReferences = [] | ||
| ExtraProjectInfo = None } | ||
| ExtraProjectInfo = None | ||
| Stamp = None } |
There was a problem hiding this comment.
What's this? Does it have to do something with file caching when recompiling a project? I recently tried setting LoadTime to Now for watch compilations to see if there's any performance improvement as recompilations may take quite long (around 10s) in some big projects, but I'm not sure it had any effect.
|
Awesome, thank you! ❤️ I saw the API changes and thought it'd be much work to update FCS 😅 Let's see if this has any performance improvement 🤞 |
…patterns - Replace unsafe `.Value` on option types with safe pattern matching in Python/Replacements.fs (#1203) and Rust/Fable2Rust.fs (#1126, #1127) - Add [<return: Struct>] to partial active patterns in Dart/Fable2Dart.fs (#1105, #1106), Dart/Replacements.fs (#1177), and Rust/Fable2Rust.fs (#1115, #1116, #1117, #1118, #1119, #1120, #1121, #1122, #1123, #1124) to reduce heap allocations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
No description provided.