check fallback datacache for cacheResultWithInsert#141
Closed
DylanZA wants to merge 1 commit intofacebook:masterfrom
Closed
check fallback datacache for cacheResultWithInsert#141DylanZA wants to merge 1 commit intofacebook:masterfrom
DylanZA wants to merge 1 commit intofacebook:masterfrom
Conversation
Summary: There are two ways into the DataFetch cache, through cacheResult, and dataFetch. The fallback only worked for dataFetch, and this diff adds cacheResult. This allows tests to inject state such as time through the fallback, and that should allow consistent tests Differential Revision: D28534164 fbshipit-source-id: 42d8b5c26e359bc53828ce2fa95131658c3aec23
|
This pull request was exported from Phabricator. Differential Revision: D28534164 |
|
This pull request has been merged in 5c49986. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: There are two ways into the DataFetch cache, through cacheResult, and dataFetch. The fallback only worked for dataFetch, and this diff adds cacheResult. This allows tests to inject state such as time through the fallback, and that should allow consistent tests
Differential Revision: D28534164