Skip to content

Tiny typo in comment #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earthrid wants to merge 13 commits into from
Closed

Tiny typo in comment #4217

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2bf0929
pin envinfo version to 3.4.2 (#3853)
bondz Jan 18, 2018
034c6ad
1.5.1
gaearon Jan 18, 2018
bab2c29
Set the public path to the asset manifest entries (#2544)
robinvdvleuten Jan 20, 2018
eee2907
Include `{json,css}` files in prettier command (#3894)
reyronald Jan 22, 2018
815853d
Update instructions for continuous delivery with Netlify (#3971)
hubgit Feb 4, 2018
32ea0c0
Update dotenv-expand to fix bug with environment variables that conta…
iansu Feb 9, 2018
09d216e
Unpin and bump fsevents (for 1.x branch) (#4006)
gaearon Feb 9, 2018
984d661
Add 1.1.1 changelog
gaearon Feb 9, 2018
1a9722f
Revert "Set the public path to the asset manifest entries (#2544)"
gaearon Feb 9, 2018
0b1d636
Publish
gaearon Feb 9, 2018
c6375ed
`.mjs` should not resolve before .js files (#4085)
leebyron Mar 22, 2018
cb1608b
Add troubleshooting for Github Pages (#4197)
Mar 23, 2018
a0d5c09
Tiny typo in comment
earthrid Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Set the public path to the asset manifest entries (#2544)" 
This reverts commit bab2c29.

I meant to apply it to `next` instead.
  • Loading branch information
@gaearon
gaearon committed Feb 9, 2018
commit 1a9722f50a8b8786803c1f784efca366a43f38da
1 change: 0 additions & 1 deletion packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ module.exports = {
// having to parse `index.html`.
new ManifestPlugin({
fileName: 'asset-manifest.json',
publicPath: publicPath
}),
// Generate a service worker script that will precache, and keep up to date,
// the HTML & assets that are part of the Webpack build.
Expand Down