Skip to content

Resolve app paths from realpath of CWD, fix #637 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 2 commits into from
Sep 16, 2016
Merged

Resolve app paths from realpath of CWD, fix #637 #648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7006b2
Resolve app paths from realpath of CWD, fix #637
motiz88 Sep 14, 2016
181bef5
Use new resolveApp() for NODE_PATH too
gaearon Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions config/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@
// @remove-on-eject-end

var path = require('path');
var fs = require('fs');

// Make sure any symlinks in the project folder are resolved:
// https://github.com/facebookincubator/create-react-app/issues/637
var appDirectory = fs.realpathSync(process.cwd());
function resolveApp(relativePath) {
return path.resolve(appDirectory, relativePath);
}

// We support resolving modules according to `NODE_PATH`.
// This lets you use absolute paths in imports inside large monorepos:
Expand All @@ -25,11 +33,7 @@ var path = require('path');
var nodePaths = (process.env.NODE_PATH || '')
.split(process.platform === 'win32' ? ';' : ':')
.filter(Boolean)
.map(p => path.resolve(p));

function resolveApp(relativePath) {
return path.resolve(relativePath);
}
.map(resolveApp);

// config after eject: we're in ./config/
module.exports = {
Expand Down