chore(v2): Remove unused deps from docusaurus-mdx-loader#3595
Merged
Conversation
lex111
reviewed
Oct 15, 2020
Contributor
lex111
left a comment
lex111
left a comment
There was a problem hiding this comment.
May need to change yarn.lock file, could you please test this change locally?
Contributor
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit ed6bf1f |
Contributor
Author
|
There won't be a change cause it's already used in docusaurus-remark-plugin-npm2yarn |
lex111
changed the title
lex111
approved these changes
Oct 15, 2020
Contributor
|
@hamzahamidi thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove unused dependency newly added in #3469 (comment)
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)