Go to selected page#4313
Closed
ben-qnimble wants to merge 7 commits into
Closed
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit a687602 https://app.netlify.com/sites/docusaurus-1/deploys/603d481c1bc5f400072bb15c |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit a687602 |
ben-qnimble
force-pushed
the
go-to-selected-page
branch
5 times, most recently
from
267c62a to
7409ade
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4313--docusaurus-2.netlify.app/classic/ |
|
Size Change: +22 B (0%) Total Size: 532 kB ℹ️ View Unchanged
|
ben-qnimble
force-pushed
the
go-to-selected-page
branch
2 times, most recently
from
50a793b to
4f7f630
Compare
ben-qnimble
force-pushed
the
go-to-selected-page
branch
from
4f7f630 to
a687602
Compare
Contributor
Author
|
Cleaner pull request with #4323 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pull #3898 looks very helpful (sidebar category linking to doc) but it seems like it got stalled, so I'm trying to get it over the finish line by addressing issues mentioned in the pull request code review.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Please see #3898. I tested the category functionality by setting a link field for a few categories. Works as expected.
Related PRs
A few additional commits to #3898 to address code review comments.