Skip to content

feat(stylelint-copyright): autofix, stricter config#6374

Merged
Josh-Cena merged 3 commits into
mainfrom
jc/stylelint-autofix
Jan 16, 2022
Merged

feat(stylelint-copyright): autofix, stricter config#6374
Josh-Cena merged 3 commits into
mainfrom
jc/stylelint-autofix

Conversation

@Josh-Cena
Copy link
Copy Markdown
Collaborator

@Josh-Cena Josh-Cena commented Jan 16, 2022

Motivation

Continuation of #6372.

I tried to migrate it to TS, but lerna doesn't build private packages because we want to exclude the packages in templates... Can't bother right now, just kept it as JS.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Already caught & autofixed two bad CSS files! It probably stopped working already after we migrated to postcss 8...

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 16, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 16, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2022

✔️ [V2]

🔨 Explore the source changes: 718fb3b

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61e38eba68f3710008e5b3f3

😎 Browse the preview: https://deploy-preview-6374--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 16, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 98
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6374--docusaurus-2.netlify.app/

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 16, 2022

Size Change: 0 B

Total Size: 677 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 41.6 kB
website/build/assets/css/styles.********.css 103 kB
website/build/assets/js/main.********.js 503 kB
website/build/index.html 29.6 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 14bec7c into main Jan 16, 2022
@Josh-Cena Josh-Cena deleted the jc/stylelint-autofix branch January 16, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants