Skip to content

test: add tests for gitUtils#6949

Merged
Josh-Cena merged 3 commits into
mainfrom
jc/test-git
Mar 21, 2022
Merged

test: add tests for gitUtils#6949
Josh-Cena merged 3 commits into
mainfrom
jc/test-git

Conversation

@Josh-Cena
Copy link
Copy Markdown
Collaborator

Motivation

Added some basic tests so this file is at least test-covered.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 21, 2022
@Josh-Cena
Copy link
Copy Markdown
Collaborator Author

/cc @felipecrs Currently the git utils seem to use the committer date. I think when you originally implemented it, you mentioned we should use the author date instead? I think that's a certainly valid idea.

@Josh-Cena
Copy link
Copy Markdown
Collaborator Author

Oh, read your reasoning in #6593. Honestly, continuously amending a commit doesn't sound like a terribly common practice, but I'm fine with this way.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 21, 2022

✅ [V2]

🔨 Explore the source changes: 18cb859

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/623853d148443500098d04a3

😎 Browse the preview: https://deploy-preview-6949--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6949--docusaurus-2.netlify.app/

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2022

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 612 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 5ee7e8c into main Mar 21, 2022
@Josh-Cena Josh-Cena deleted the jc/test-git branch March 21, 2022 10:40
@Josh-Cena
Copy link
Copy Markdown
Collaborator Author

Oops, forgot to check Windows status again...

@felipecrs
Copy link
Copy Markdown
Contributor

The tests turned out great, by the way. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants