fix(core): inject docusaurus version into SSR as local#7329
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR
|
Josh-Cena
left a comment
There was a problem hiding this comment.
The remaining warning in our log is unrelated and quite intractable to fix. Thanks for narrowing down to the real cause!
|
great 👍 |
|
@slorber Do you think this is worth a hotfix release? It'll likely confuse other users, although it's not actually critical (because it's the server build). We'll have to wait for another month otherwise. |
|
yes I'll likely do one, hopefully all important bugs will be reported before the end of the day otherwise I can still do a release later but I'd prefer not to |
|
Yes, let's collect some more feedback... 'Bit unfortunate it's either today or half a month later |
Bug caused by #7187
This commit causes all sorts of issues because webpack can't analyze the package.json entry.
E.g.:
By injecting it, the deploy preview log no longer shows the errors: https://app.netlify.com/sites/docusaurus-2/deploys/627322423fef010008c50bb6