Skip to content

docs: document usage of docs frontMatter.custom_edit_url: null#8053

Merged
slorber merged 1 commit into
facebook:mainfrom
homotechsual:patch-2
Sep 7, 2022
Merged

docs: document usage of docs frontMatter.custom_edit_url: null#8053
slorber merged 1 commit into
facebook:mainfrom
homotechsual:patch-2

Conversation

@homotechsual
Copy link
Copy Markdown
Contributor

@homotechsual homotechsual commented Sep 6, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Documents null value behaviour for custom_edit_url frontmatter.

Test Plan

N/A Docs Only

Test links

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 6, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 6, 2022

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit af7bda7
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6317416fb4527500082aca65
😎 Deploy Preview https://deploy-preview-8053--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 6, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 76 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 78 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 7, 2022
@slorber slorber changed the title Document null value for custom_edit_url docs: document usage of frontMatter.custom_edit_url: null Sep 7, 2022
slorber
slorber approved these changes Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@slorber slorber changed the title docs: document usage of frontMatter.custom_edit_url: null docs: document usage of docs frontMatter.custom_edit_url: null Sep 7, 2022
@slorber slorber merged commit e507628 into facebook:main Sep 7, 2022
slorber pushed a commit that referenced this pull request Sep 7, 2022
@homotechsual @slorber
docs: document usage of docs frontMatter.custom_edit_url: null (#8053)
abf52e3
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@homotechsual @slorber @facebook-github-bot