Add accessibilityElementsHidden prop#141
Merged
charpeni merged 1 commit intofacebook:masterfrom Mar 14, 2018
aputinski:accessibility
Merged
Add accessibilityElementsHidden prop#141charpeni merged 1 commit intofacebook:masterfrom aputinski:accessibility
charpeni merged 1 commit intofacebook:masterfrom
aputinski:accessibility
Conversation
hramos
approved these changes
Jan 16, 2018
Contributor
hramos
left a comment
hramos
left a comment
There was a problem hiding this comment.
Let's wait for that PR to land, then we can merge.
Contributor
Author
|
Thanks! |
charpeni
added
the
🕐 Waiting on PR
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 29, 2018
Summary: Allow iOS to have similar accessibility functionality to Android. This PR exposes the `accessibilityElementsHidden` property on iOS which is similar to Android's `importantForAccessibility="no-hide-descendants"` I didn't see any existing examples for testing native props being passed through, but I did add an example to the RNTester app. I've attached some screenshots using the Accessibility Inspector to verify the property was correctly passed through.   I've updated the website with appropriate documentation. facebook/react-native-website#141   [IOS] [FEATURE] [View] - Added accessibilityElementsHidden property Closes #17627 Differential Revision: D6806444 Pulled By: hramos fbshipit-source-id: 50d31fdb92f4c59ae9355b019c422418b2e6cc24
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Mar 1, 2018
Summary: Allow iOS to have similar accessibility functionality to Android. This PR exposes the `accessibilityElementsHidden` property on iOS which is similar to Android's `importantForAccessibility="no-hide-descendants"` I didn't see any existing examples for testing native props being passed through, but I did add an example to the RNTester app. I've attached some screenshots using the Accessibility Inspector to verify the property was correctly passed through.   I've updated the website with appropriate documentation. facebook/react-native-website#141   [IOS] [FEATURE] [View] - Added accessibilityElementsHidden property Closes facebook/react-native#17627 Differential Revision: D6806444 Pulled By: hramos fbshipit-source-id: 50d31fdb92f4c59ae9355b019c422418b2e6cc24
charpeni
approved these changes
Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated documentation for facebook/react-native#17627