default value of textBreakStrategy prop for TextInput is not 'simple'

[aswin-s]

Description

The document mentions that the default value of textBreakStrategy for TextInput component is 'simple'. However on Android device it behaves like highQuality strategy.

React Native Version

0.72.1

Output of npx react-native info

➜  AwesomeProject npx react-native info
info Fetching system and libraries information...
System:
  OS: macOS 13.4.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 780.70 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 16.17.0
    path: ~/.nvm/versions/node/v16.17.0/bin/node
  Yarn:
    version: 1.22.19
    path: ~/.nvm/versions/node/v16.17.0/bin/yarn
  npm:
    version: 8.15.0
    path: ~/.nvm/versions/node/v16.17.0/bin/npm
  Watchman:
    version: 2023.06.12.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /opt/homebrew/lib/ruby/gems/3.0.0/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK:
    API Levels:
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
    Build Tools:
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 33.0.0
      - 33.0.0
    System Images:
      - android-32 | Google APIs ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2022.2 AI-222.4459.24.2221.10121639
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.11
    path: /usr/bin/javac
  Ruby:
    version: 3.2.2
    path: /opt/homebrew/opt/ruby/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.1
    wanted: 0.72.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Steps to reproduce

• Create a new react-native app
• Replace App.tsx with below content

import {TextInput, View} from 'react-native';
import React from 'react';

function App(): JSX.Element {
  const [value, setValue] = React.useState(
    'applicationtestuser+23456izv2604@staging.example.com',
  );
  return (
    <View style={{padding: 20, justifyContent: 'center', flex: 1}}>
      <TextInput
        value={value}
        onChangeText={setValue}
        style={{fontSize: 20, color: 'black', borderWidth: 1}}
        multiline
      />
    </View>
  );
}

export default App;

• Run the app on an android device / simulator
• Check how the content inside text input gets wrapped
• Edit the value of the TextInput by deleting characters from the end
• Observe how the text wrapping keeps on changing while characters gets removed.

Snack, code example, screenshot, or link to a repository

https://snack.expo.dev/EXM6N4Rkm

[aswin-s]

Default value of textBreakStrategy for TextInput is being initialised to highQuality here. However as per documentation default value of textBreakStrategy should be simple. Android documentation also sets the same expectation for EditText component, as highQuality strategy would cause the text to "dance around" while user types in the input.

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java

Lines 56 to 59 in 50f620a

	mTextBreakStrategy =
	(Build.VERSION.SDK_INT < Build.VERSION_CODES.M)
	? Layout.BREAK_STRATEGY_SIMPLE
	: Layout.BREAK_STRATEGY_HIGH_QUALITY;

I'm still not able to figure out where is the default value being set for newArchitecture. As far as I could decipher default value for textBreakStrategy is being read from ParagraphAttributes. This value is shared with Text component and the default value should be highQuality

react-native/packages/react-native/ReactCommon/react/renderer/attributedstring/ParagraphAttributes.h

Lines 45 to 47 in 50f620a

	* (Android only) Break strategy for breaking paragraphs into lines.
	*/
	TextBreakStrategy textBreakStrategy{TextBreakStrategy::HighQuality};

[aswin-s]

Can we initialise textBreakStrategy for AndroidTextInput at any of the below lines, so that it will not impact other Text related components?

react-native/packages/react-native/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.h

Line 87 in 50f620a

std::string textBreakStrategy{};

react-native/packages/react-native/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.cpp

Lines 63 to 66 in 50f620a

	textBreakStrategy(CoreFeatures::enablePropIteratorSetter? sourceProps.textBreakStrategy : convertRawProp(context, rawProps,
	"textBreakStrategy",
	sourceProps.textBreakStrategy,
	{})),