Fix flaky TaskDispatchThreadTest/RunAsyncWithDelay timing test#57041
Closed
cortinico wants to merge 1 commit into
Closed
Fix flaky TaskDispatchThreadTest/RunAsyncWithDelay timing test#57041cortinico wants to merge 1 commit into
TaskDispatchThreadTest/RunAsyncWithDelay timing test#57041cortinico wants to merge 1 commit into
Conversation
Summary: Replace tight `sleep_for` margins with a `std::promise`/`std::future` synchronization pattern. The old test used `sleep_for(50ms)` and `sleep_for(70ms)` to bracket a 100ms delayed task, which failed on loaded CI machines when timers fired early or late (98.7% flakiness score). The new approach uses `sleep_for(20ms)` for the "not yet executed" check (well before the 200ms delay) and `future.wait_for(5s)` for the "completed" check, eliminating timing sensitivity entirely. Changelog: [Internal] Differential Revision: D107232190
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107232190. |
Collaborator
|
This pull request was successfully merged by @cortinico in e208aa0 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in e208aa0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace tight
sleep_formargins with astd::promise/std::futuresynchronization pattern. The old test usedsleep_for(50ms)andsleep_for(70ms)to bracket a 100ms delayed task, which failed on loaded CI machines when timers fired early or late (98.7% flakiness score). The new approach usessleep_for(20ms)for the "not yet executed" check (well before the 200ms delay) andfuture.wait_for(5s)for the "completed" check, eliminating timing sensitivity entirely.Changelog: [Internal]
Differential Revision: D107232190