[CLI] add swift-bridge command to generate swift bridging header#3103
Closed
nsimmons wants to merge 1 commit intofacebook:masterfrom
nsimmons:cli/swift_bridge_command
Closed
[CLI] add swift-bridge command to generate swift bridging header#3103nsimmons wants to merge 1 commit intofacebook:masterfrom nsimmons:cli/swift_bridge_command
nsimmons wants to merge 1 commit intofacebook:masterfrom
nsimmons:cli/swift_bridge_command
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
You're on a roll. Keep it up. 🐦 |
Contributor
|
@nsimmons This is a very useful PR. Would love to get it merged. Can you rebase it against master? |
Contributor
|
Closing since no activity on the PR. let's re-open if you wanna work on it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1669
I added a command to the CLI to generate the import statements needed for the Swift bridging header. You pass in the comma separated list of all the ReactNative pod specs / projects you added to your app and it will spit out what you need to the console, or directly into a file with the
--outoption.I updated the Docs website to include this step for Swift devs.
@yelled3 have a look and let me know if this solves your issue.
@brentvatne for review as well. This goes along with my other swift PR.